Remove Symfony Controller Hook After Execution #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROFeNoM
force-pushed
the
alex/issue/gh2427
branch
from
fe01358 to
bf900b4
Compare
BenchmarksBenchmark execution time: 2024-01-10 14:09:33 Comparing candidate commit in PR branch `` with baseline commit 41cb273 in branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 37 metrics, 52 unstable metrics. scenario:PHPRedisBench/benchRedisBaseline
|
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From issue #2427, it appears that the current way of tracing controllers conflicts with long-running processes. The artifact from this branch was tested by the reporter and addressed his issue.
This PR removes the hook installed on the controller after it was executed, as it is done in some other integrations (e.g., LaravelQueue, Laminas)
Reviewer checklist